-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Core} Extension Breaking Change Announcement Instruction #30975
base: dev
Are you sure you want to change the base?
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
6c42404
to
f209cca
Compare
* Service Owned Module | ||
* Service Team should create a Pull Request that create the pre-announcement several sprints ahead Breaking Change Window. | ||
* The pre-announcement should be released ahead of Breaking Change Window. | ||
* The pre-announcement should be released at least **2** sprints ahead of Breaking Change Window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually I suppose sprint will vary across team, but monthly basis is often adopted.
If we put as 1-month policy above(Line 32), we might keep it aligned here, rather than 2 sprints, right?
* The pre-announcement should be released ahead of Breaking Change Window. | ||
* The pre-announcement should be released at least **2** sprints ahead of Breaking Change Window. | ||
* **Service Owned Module** | ||
* Service Team should create a Pull Request that adds the pre-announcement at least **2** sprints ahead of Breaking Change Window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
* The pre-announcement should be released at least **2** sprints ahead of Breaking Change Window. | ||
* **Service Owned Module** | ||
* Service Team should create a Pull Request that adds the pre-announcement at least **2** sprints ahead of Breaking Change Window. | ||
* The pre-announcement should be released at least **2** sprints ahead of Breaking Change Window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
Related command
Description
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.